This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
fix: don't consider velocity and gesture distance if gesture didn't end #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/fix-tab-change
branch
3 times, most recently
from
01bc244 to
f4bba71
Compare
previously, when gesture wasn't active, we checked if the gesture exceeded the minimum threshold (this was due to activeOffsetX not being respected on Android), - if yes, we calculate the next position based on gesture distance or velocity - if no, we transition to what the value of index was this addressed 2 cases: the first condition would trigger when a gesture was performed, the second one will trigger if the index changed due to other means such as state update. this check was mistakenly removed in e7f832c the new code checked for `State.END`, which resulted in the tab switch due to state update not working at times. this is because the `gestureState` value is different when a gesture was cancelled, e.g. due to a vertical gesture or focus on an input element. closes #806, closes #809
satya164
force-pushed
the
@satya164/fix-tab-change
branch
from
f4bba71 to
1cefb27
Compare
osdnk
approved these changes
Jun 21, 2019
|
Can someone make a release? My internet connection here is too slow to install |
Nah. I should've written some comments initially on why that was done. Easy mistake to make 😃 |
ankeetmaini
pushed a commit
to ankeetmaini/react-native-tab-view
that referenced
this pull request
Jul 7, 2019
…nd (satya164#810) previously, when gesture wasn't active, we checked if the gesture exceeded the minimum threshold (this was due to activeOffsetX not being respected on Android), - if yes, we calculate the next position based on gesture distance or velocity - if no, we transition to what the value of index was this addressed 2 cases: the first condition would trigger when a gesture was performed, the second one will trigger if the index changed due to other means such as state update. this check was mistakenly removed in satya164@e7f832c the new code checked for `State.END`, which resulted in the tab switch due to state update not working at times. this is because the `gestureState` value is different when a gesture was cancelled, e.g. due to a vertical gesture or focus on an input element. closes satya164#806, closes satya164#809
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, when gesture wasn't active, we checked if the gesture exceeded the minimum threshold (this was due to activeOffsetX not being respected on Android),
this addressed 2 cases: the first condition would trigger when a gesture was performed, the second one will trigger if the index changed due to other means such as state update.
this check was mistakenly removed in e7f832c
the new code checked for
State.END, which resulted in the tab switch due to state update not working at times. this is because thegestureStatevalue is different when a gesture was cancelled, e.g. due to a vertical gesture or focus on an input element.closes #806, closes #809