Http error callback #885
Merged
Http error callback #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojason117
force-pushed
the
httpErrorStatusCode
branch
from
e184e51
to
0480efe
Compare
|
What is the difference between that and onLoadingError ? |
|
@Titozzz I assume you are talking about the |
react-native-community-bot
pushed a commit
that referenced
this pull request
Sep 21, 2019
# [7.1.0](v7.0.7...v7.1.0) (2019-09-21) ### Bug Fixes * **iOS:** Call dispatchViewManagerCommand with correct number of arguments ([#886](#886)) ([33f1ee3](33f1ee3)) * **iOS:** inconsistent backgroundColor ([#868](#868)) ([d25b20a](d25b20a)) ### Features * **iOS:** Allow custom CA to be used on webview requests ([#865](#865)) ([136fbd8](136fbd8)) * **new prop:** onHttpError callback ([#885](#885)) ([552472c](552472c))
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ryan007008
added a commit
to joycastle/react-native-webview
that referenced
this pull request
Oct 12, 2019
* master: (182 commits) chore(release): 7.2.5 [skip ci] fix(types): Make onContentProcessDidTerminate optional (react-native-webview#890) chore(release): 7.2.4 [skip ci] fix(android): Revert scroll update from react-native-webview#281 (react-native-webview#889) chore(release): 7.2.3 [skip ci] fix(iOS): Xcode issues and warnings (no functionality changes) (react-native-webview#860) chore(release): 7.2.2 [skip ci] fix(android): redirect and renderLoading issues (react-native-webview#548) chore(release): 7.2.1 [skip ci] fix(android): Filter extra onLoadProgress & add url event (react-native-webview#643) chore(release): 7.2.0 [skip ci] feat(iOS): Add callback for webViewWebContentProcessDidTerminate (react-native-webview#774) chore(release): 7.1.1 [skip ci] fix(Android): hardware acceleration issue (react-native-webview#854) chore(release): 7.1.0 [skip ci] feat(iOS): Allow custom CA to be used on webview requests (react-native-webview#865) feat(new prop): onHttpError callback (react-native-webview#885) fix(iOS): Call dispatchViewManagerCommand with correct number of arguments (react-native-webview#886) fix(iOS): inconsistent backgroundColor (react-native-webview#868) chore(release): 7.0.7 [skip ci] ... # Conflicts: # android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java # ios/RNCUIWebView.h # ios/RNCUIWebView.m # ios/RNCUIWebViewManager.m # ios/RNCWebView.h # ios/RNCWebView.m # ios/RNCWebViewManager.m # js/WebView.android.js # js/WebView.ios.js # js/WebViewTypes.js # typings/index.d.ts
phuongwd
pushed a commit
to phuongwd/react-native-webview
that referenced
this pull request
Apr 29, 2020
phuongwd
pushed a commit
to phuongwd/react-native-webview
that referenced
this pull request
Apr 29, 2020
# [7.1.0](react-native-webview/react-native-webview@v7.0.7...v7.1.0) (2019-09-21) ### Bug Fixes * **iOS:** Call dispatchViewManagerCommand with correct number of arguments ([react-native-webview#886](react-native-webview#886)) ([33f1ee3](react-native-webview@33f1ee3)) * **iOS:** inconsistent backgroundColor ([react-native-webview#868](react-native-webview#868)) ([d25b20a](react-native-webview@d25b20a)) ### Features * **iOS:** Allow custom CA to be used on webview requests ([react-native-webview#865](react-native-webview#865)) ([136fbd8](react-native-webview@136fbd8)) * **new prop:** onHttpError callback ([react-native-webview#885](react-native-webview#885)) ([552472c](react-native-webview@552472c))
5 tasks
noproblem23
added a commit
to noproblem23/react-native-webview
that referenced
this pull request
Apr 18, 2023
# [7.1.0](react-native-webview/react-native-webview@v7.0.7...v7.1.0) (2019-09-21) ### Bug Fixes * **iOS:** Call dispatchViewManagerCommand with correct number of arguments ([#886](react-native-webview/react-native-webview#886)) ([33f1ee3](react-native-webview/react-native-webview@33f1ee3)) * **iOS:** inconsistent backgroundColor ([#868](react-native-webview/react-native-webview#868)) ([d25b20a](react-native-webview/react-native-webview@d25b20a)) ### Features * **iOS:** Allow custom CA to be used on webview requests ([#865](react-native-webview/react-native-webview#865)) ([136fbd8](react-native-webview/react-native-webview@136fbd8)) * **new prop:** onHttpError callback ([#885](react-native-webview/react-native-webview#885)) ([552472c](react-native-webview/react-native-webview@552472c))
jaynilson
added a commit
to jaynilson/reactNative_service_USA
that referenced
this pull request
Sep 11, 2024
# [7.1.0](react-native-webview/react-native-webview@v7.0.7...v7.1.0) (2019-09-21) ### Bug Fixes * **iOS:** Call dispatchViewManagerCommand with correct number of arguments ([#886](react-native-webview/react-native-webview#886)) ([33f1ee3](react-native-webview/react-native-webview@33f1ee3)) * **iOS:** inconsistent backgroundColor ([#868](react-native-webview/react-native-webview#868)) ([d25b20a](react-native-webview/react-native-webview@d25b20a)) ### Features * **iOS:** Allow custom CA to be used on webview requests ([#865](react-native-webview/react-native-webview#865)) ([136fbd8](react-native-webview/react-native-webview@136fbd8)) * **new prop:** onHttpError callback ([#885](react-native-webview/react-native-webview#885)) ([552472c](react-native-webview/react-native-webview@552472c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
onHttpErrorcallback which notifies the host app that an error http status code is received.After finishing the code I found out there's already a closed PR for this feature but it never get merged, so I figure I'll just mention it here and I've also addressed to most of the comments in that PR.
Http error callback (Catch http error statuscode) #558
It's useful to be able to get the error status code in the webview, so that we can have different error handlings based on the status code (e.g. refresh token on
401).Requests for nested frames are filtered out, so
onHttpErrorwill only be called on the main frame.The native event returned from this callback will contain:
statusCode: The http error status code.description: Description of the error status code (only onAndroid).Implementation:
iOS:decidePolicyForNavigationResponseAndroid:onReceivedHttpError(introduced in API level 23)Fixes #189
Fixes #807
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)