Upcoming v0.63.4 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.3 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[hsavit1]

this one would save me so much pain facebook/react-native#30027

[kelset]

@hsavit1 that's an open PR, so we can't cherry pick it. For something to be cherry-pickable, we need for PRs to be merged in master and we need the commit hash to be posted here :)

[kelset]

hey folks, today I've been able to dedicate some time to the releases so I went through all the comments above that added a commit and this is the full list of asked cherry-pickables for 0.63.4, ordered (from oldest to newest):

• facebook/react-native@ed29ba1 ✅
• facebook/react-native@30cc158 ✅
• facebook/react-native@0348953 ✅
• facebook/react-native@797367c ✅
• facebook/react-native@4b956fe ✅
• facebook/react-native@9e85b7a ✅
• facebook/react-native@f319ff3 ✅
  • conflict on podlock, regerated through pod install
• facebook/react-native@0f6fcb2 ✅
• facebook/react-native@7465239 ✅
• facebook/react-native@1015194 ✅
• facebook/react-native@748aa13 ✅
• facebook/react-native@53f5500 ✅
• facebook/react-native@bb8d0f5 ✅
• facebook/react-native@00d9dea ✅
  • conflict on ReactEditText.java, luckily the commit itself is quite small so I can replicate the change manually
• facebook/react-native@0e9296b ✅
• facebook/react-native@d85d5d2 🙅‍♂️
  • conflict is multifile and fairly complicated, so I'm backing out of it

I'll be honest, it's quite a big list and given how some commits have landed so much after 0.63 was cut, it's realistic to expect some of the cherry picks to create issues. I'll update you after I've attempted to cherry pick & test locally, which will happen either tomorrow or next week.

---

Note to self: I may need to cherry pick this too facebook/react-native#29868 - facebook/react-native@fb14fd4

• ended up manually replicating the change

---

EDIT: updated to reflect the status of cherry-picking attempt ongoing.

[MoKhajavi75]

Thanks for all your efforts @kelset ❤

[kelset]

hey folks - quick update: I finally got some time to spare to dedicate to this, I've done the cherry pick (see details above, I managed to pick everything but the last one listed about Modal's onDismiss), and local testing. Everything went fairly smoothly and all was good during testing 👍

I'm now updating the remote branch so that CI can also run its tests and I'll ask to the other maintainers if they can double check / run a local test on their machine just to make sure.

Since it's Friday at this point I'd guess Monday I'll be able to get the release out.

[renatobenks]

that's a great news @kelset!

[kelset]

RN 0.63.4 is out!
I hope this release with help you all, it took a while but hopefully my testing was good and there are no regressions introduced 🤗

The changelog is still in PR phase but you can check it out here: #217

I'm going to close this and open a new one for next version (if that happens).