Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorCodes and isErrorWithCode are not correctly exported with '@react-native-documents/viewer' #795

Closed
1 task done
930r91na opened this issue Mar 18, 2025 · 2 comments · Fixed by #796
Closed
1 task done

Comments

@930r91na
Copy link
Contributor

I have searched open and closed issues for this issue.

  • I have searched open and closed issues.

Minimal reproducible example

null

What platform(s) does this occur on?

Android

Steps to reproduce

Try importing modules like this:
import { viewDocument, errorCodes, isErrorWithCode } from '@react-native-documents/viewer';

you will get that there is no modules for the ones exported in error.ts

Image

Your computer environment

npx react-native info
info Fetching system and libraries information...
System:
  OS: Windows 11 10.0.22631
  CPU: (16) x64 13th Gen Intel(R) Core(TM) i7-13620H
  Memory: 492.06 MB / 15.74 GB
Binaries:
  Node:
    version: 23.9.0
    path: C:\nvm4w\nodejs\node.EXE
  Yarn: Not Found
  npm:
    version: 10.9.2
    path: C:\nvm4w\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK: Not Found
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.13.35825.156 (Visual Studio Community 2022)
Languages:
  Java: 22.0.2
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
@vonovak
Copy link
Member

vonovak commented Mar 18, 2025

Hello and thanks for asking,
this should be super trivial to fix, can you open a PR?

Thank you 🙂

@930r91na
Copy link
Contributor Author

I opened a PR with the fix
#796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants