Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support RN 0.40.0 #177

Closed
mrKlar opened this issue Jan 6, 2017 · 11 comments
Closed

support RN 0.40.0 #177

mrKlar opened this issue Jan 6, 2017 · 11 comments

Comments

@mrKlar
Copy link
Contributor

mrKlar commented Jan 6, 2017

Hi,

breaking change in RN 0.40.0 demands that the imports be redefined.

facebook/react-native#11725

A bunch of these need to be converted. If it says #import "RCTConvert.h", it needs to change to #import <React/RCTConvert.h>

thanks,

@tlvenn
Copy link

tlvenn commented Jan 9, 2017

Hi @mrKlar, why not send a PR ? This seems like an easy fix and I am sure the author would welcome the help.

@Freddy03h
Copy link

He did it : #178
I tested it and it solve the issue.

@monzerhijazi
Copy link

+1

@Luzgan
Copy link

Luzgan commented Jan 11, 2017

I am still having problem with #import <React/RCTViewManager.h>in RNGoogleSigninButtonManager.m. It might be because of incorrect search paths or something but the other errors went away after updating. Any ideas?

@maxh
Copy link
Contributor

maxh commented Jan 12, 2017

We may also want this docs update for 0.40: #181

@yangli-io
Copy link

+1

@ujwal-setlur
Copy link

Will there be a release for RN 0.40 anytime soon?

@mrKlar
Copy link
Contributor Author

mrKlar commented Feb 11, 2017

Please publish to npm

@ujwal-setlur
Copy link

I need this too, so for now I am drawing from the forked repo. Thanks @mrKlar !

@Kerumen
Copy link
Collaborator

Kerumen commented Mar 3, 2017

Published as v0.9.0! 🎉

Sorry for the delay everyone. @devfd added me as collaborator today, I will focus on maintaining this module up to date.

@Kerumen Kerumen closed this as completed Mar 3, 2017
@ujwal-setlur
Copy link

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants