-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] onValueChange stopped firing event for false values (null, undefined, 0, "", false, etc) #590
Comments
Same issue on Android. I can set empty string as a value on the iOS device. But I can not set empty string as a value on the Android device. It does not trigger onValueChange. on the iOS device, it works. |
Any updates? Sorry but I really need this fixed. |
@dmk3141618 temporary fix, if you haven't tired, is downgrading to |
@didley But I am using RN 0.76.3 New Architecture |
@dmk3141618 Ahh thats unfortunate. I've just opened a PR. It's a one line fix, so hopefully it can get looked at and merged shortly. |
Library version: 2.8.1
React native version: 0.74.6
After upgrading from 7.6.2 to 8.2.0, the
onValueChange
handler stopped being called for false values (false, "", undefined, null, etc).It seems it also stopped firing event on placeholder touch event. See this thread.
After some research I found where the breaking change has been introduced: here
IMO it's should be up to the developer to interpret the value returned by the picker. If null is meant to represent the placeholder value, then it should be the developer responsibility to handle that null value from it's onValueChange handler. I don't think the values should be muted from within the picker implementation.
In other words, this change should probably be reverted
The text was updated successfully, but these errors were encountered: