Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Props are not handled as expected #13

Open
gavrilikhin-d opened this issue Feb 13, 2024 · 5 comments
Open

Props are not handled as expected #13

gavrilikhin-d opened this issue Feb 13, 2024 · 5 comments
Labels
confirmed The issue has been confirmed enhancement New feature or request

Comments

@gavrilikhin-d
Copy link

Describe the bug
If you use mirror prop, then you would get:

Warning: Received `true` for a non-boolean attribute `mirror`.

If you want to write it to the DOM, pass a string instead: mirror="true" or mirror={value.toString()}.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)

Versions (please complete the following information):

  • React Native Version: 0.73.2
  • React Native Web Version: 0.19.10
  • React Native WebRTC Version: 118.0.0
@gavrilikhin-d
Copy link
Author

Same goes for objectFit

Warning: React does not recognize the `objectFit` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `objectfit` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)

@gavrilikhin-d
Copy link
Author

And zOrder :)

agent.ts:1 Warning: React does not recognize the `zOrder` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `zorder` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)

@8BallBomBom 8BallBomBom added enhancement New feature or request confirmed The issue has been confirmed labels Feb 13, 2024
@8BallBomBom
Copy link
Member

8BallBomBom commented Feb 13, 2024

Planned for the next release, can't confirm exact functionality at this point 🤔
But the idea is to have everything function the same between platforms.

@8BallBomBom 8BallBomBom changed the title mirror prop is not handled as expected Props are not handled as expected Feb 13, 2024
@DavidGOrtega
Copy link

DavidGOrtega commented Jun 6, 2024

👋 When is the next release?

@8BallBomBom
Copy link
Member

Currently focused on a few projects including new arch support for the main rn webrtc repo.
But this is planned to be worked on within the coming weeks in-between that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The issue has been confirmed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants