Skip to content
This repository has been archived by the owner on Feb 8, 2020. It is now read-only.

fix: wrap reset and resetRoot inside transaction #189

Merged
merged 2 commits into from
Nov 29, 2019

Conversation

osdnk
Copy link
Member

@osdnk osdnk commented Nov 27, 2019

@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #189 into master will decrease coverage by 0.17%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   93.35%   93.18%   -0.18%     
==========================================
  Files          36       36              
  Lines         768      763       -5     
  Branches      194      201       +7     
==========================================
- Hits          717      711       -6     
- Misses         42       43       +1     
  Partials        9        9
Impacted Files Coverage Δ
packages/core/src/NavigationContainer.tsx 88.46% <86.36%> (-1.02%) ⬇️
packages/core/src/useOnAction.tsx 96.77% <0%> (-0.29%) ⬇️
packages/routers/src/StackRouter.tsx 96.96% <0%> (-0.09%) ⬇️
packages/routers/src/DrawerRouter.tsx 87.5% <0%> (ø) ⬆️
packages/core/src/useNavigationBuilder.tsx 98.76% <0%> (ø) ⬆️
packages/core/src/useNavigationHelpers.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e715ef...4a379e5. Read the comment docs.

@satya164 satya164 merged commit 5a0dfa1 into master Nov 29, 2019
@satya164 satya164 deleted the @osdnk/reset-as-a-transaction branch November 29, 2019 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UseIsFocused wrong value after resetRoot()
3 participants