This repository has been archived by the owner on Feb 8, 2020. It is now read-only.
feat: handle navigating with both with both key and name #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 93.32% 93.48% +0.16%
==========================================
Files 31 31
Lines 659 660 +1
Branches 166 160 -6
==========================================
+ Hits 615 617 +2
Misses 37 37
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
satya164
reviewed
Aug 29, 2019
| (payload.hasOwnProperty('key') && payload.hasOwnProperty('name')) || | ||
| (!payload.hasOwnProperty('key') && !payload.hasOwnProperty('name')) | ||
| ) { | ||
| if (!payload.hasOwnProperty('key') && !payload.hasOwnProperty('name')) { |
There was a problem hiding this comment.
I think we also need update the signature of the first overload
satya164
approved these changes
Aug 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.