Skip to content

Commit

Permalink
Merge pull request #13 from gor181/labels-not-updated-#11
Browse files Browse the repository at this point in the history
Labels not updated
fixes #11
  • Loading branch information
gor181 authored Aug 6, 2016
2 parents 4b05ad2 + 8f57eb7 commit 07e3189
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 17 deletions.
8 changes: 2 additions & 6 deletions dist/react-chartjs-2.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,21 +100,17 @@ var ChartComponent = _react2['default'].createClass({
},

updateChart: function updateChart() {
var _this = this;

var _props = this.props;
var data = _props.data;
var options = _props.options;

if (!this.chart_instance) return;

if (options) {
_chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
this.chart_instance.options = _chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
}

data.datasets.forEach(function (dataset, index) {
_this.chart_instance.data.datasets[index] = dataset;
});
this.chart_instance.config.data = _extends({}, this.chart_instance.config.data, data);

this.chart_instance.update();
},
Expand Down
2 changes: 1 addition & 1 deletion dist/react-chartjs-2.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 2 additions & 6 deletions lib/Chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,17 @@ var ChartComponent = _react2['default'].createClass({
},

updateChart: function updateChart() {
var _this = this;

var _props = this.props;
var data = _props.data;
var options = _props.options;

if (!this.chart_instance) return;

if (options) {
_chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
this.chart_instance.options = _chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
}

data.datasets.forEach(function (dataset, index) {
_this.chart_instance.data.datasets[index] = dataset;
});
this.chart_instance.config.data = _extends({}, this.chart_instance.config.data, data);

this.chart_instance.update();
},
Expand Down
9 changes: 5 additions & 4 deletions src/Chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,13 @@ const ChartComponent = React.createClass({
if (!this.chart_instance) return;

if (options) {
Chart.helpers.configMerge(this.chart_instance.options, options);
this.chart_instance.options = Chart.helpers.configMerge(this.chart_instance.options, options);
}

data.datasets.forEach((dataset, index) => {
this.chart_instance.data.datasets[index] = dataset;
});
this.chart_instance.config.data = {
...this.chart_instance.config.data,
...data
};

this.chart_instance.update();
},
Expand Down

0 comments on commit 07e3189

Please sign in to comment.