Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve deprecated to-iso-string warning #1395

Closed
aaronjudd opened this issue Sep 16, 2016 · 5 comments
Closed

resolve deprecated to-iso-string warning #1395

aaronjudd opened this issue Sep 16, 2016 · 5 comments
Assignees
Milestone

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Sep 16, 2016

Resolve npm warnings introduced by (I think) by wdio-mocha-framework (which is a devDependency). I believe this was introduced in #1315

Reinstalling node_modules...
npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

Might be just needing updated packages, or might need more (PR to projects?)...

@aaronjudd aaronjudd added this to the v0.16.0 milestone Sep 16, 2016
@aaronjudd aaronjudd removed this from the v0.16.0 milestone Sep 16, 2016
@Capt-Slow
Copy link
Contributor

After doing some serious digging this is what I found.

wdio-mocha-framework is using an older version of mocha 2.3.3. I found the following when going through mocha issues.

mochajs/mocha#2200

"npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade

....
We cannot upgrade to pug atm as this would cause old versions of npm to fail. For now we support Node.js v0.8.x out of the box. Support will be dropped @ next major." --mocha dev

mochajs/mocha#2350

They released mocha v3.0.0 which contains the dependency fixes.

So I forked wdio-mocha-framework and changed mocha version to 3. This eliminated the warnings we get at startup. I found that I was unable to use the standard fork. So I installed all npm modules for wdio-mocha-framework and pushed it to my fork. This almost worked, but I found there are further mocha version dependencies in the code. Not an easy fix from what I'm able to gather.

So I reached out to the webdriverio devs...

screen shot 2016-09-16 at 3 47 22 pm

So there's that. I was told if it doesn't cause any conflicts to just ignore - for now.

I looked at nightwatchjs out of curiosity and it appears they have the same issues.

nightwatchjs/nightwatch#996

Everyone appears to be ignoring these. The reason this hasn't been fixed is due to backwards compatibility with earlier versions of npm.

@aaronjudd aaronjudd added this to the v0.19.0 milestone Sep 17, 2016
@kieckhafer kieckhafer self-assigned this Dec 20, 2016
@kieckhafer
Copy link
Member

This seems to no longer be an issue.

@brent-hoover
Copy link
Collaborator

I am still seeing npm WARN deprecated node-uuid@1.4.7: use uuid module instead when doing a reaction reset and deleting node modules

@kieckhafer
Copy link
Member

kieckhafer commented Dec 20, 2016

Yes, i'm seeing that too. I'll look into that and make a PR, this issue is related to an older warning we were seeing though that I don't see anymore.

Scratch that, I see it's related now.

@kieckhafer
Copy link
Member

kieckhafer commented Dec 21, 2016

Looks like three of our npm packages use node-uuid, I'm submitting PR requests to either move from node-uuid to uuid if that makes most sense, or submitting PR requests bumping dependency versions when that makes sense.

winstonjs/node-loggly#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants