[PDP] Upgrade from 0.16.0 product

[aaronjudd]

Upgrading from a shop with 0.16.0 product causes some unexpected visibility issues.

Expected behavior

That a product from a pre 0.17.0 release should smoothly migrate without issue to a 0.17.0 product with revisions.

Actual Behavior

Product grids display "No products found".

Steps to Reproduce the Behavior

something like this...

reaction init -b master
reaction
git checkout development

[brent-hoover]

I am pretty sure it has something to do with this:

reaction/server/publications/collections/products.js

Line 83 in 8b005c8

isDeleted: false,

Possibly just a migration to add this field and set it to false would do the trick?

[brent-hoover]

Or am I just stating the suuuper obvious here

[aaronjudd]

or just isDeleted: {$in: [null, false]},?

[brent-hoover]

Does that work if the field doesn't exist? If so, yeah that's way better. I'm testing now.

[aaronjudd]

Product view would need an update as well,

reaction/server/publications/collections/product.js

Line 25 in 8b005c8

selector.isDeleted = false;

could be

selector.isDeleted = {$in: [null, false]};

[brent-hoover]

So I also noticed when on this migrate path I get the old PDP page rather than the new version. Is that intentional or do I need to turn revisions on somewhere?

[brent-hoover]

I have revision control enabled but get the old PDP page so no revision control.