Docker images should default to installing mongo

[aaronjudd]

A primary purpose (or at least, nice side role) of our docker images is that they are used for demo/testing initially by many people checking out Reaction.

Reaction images should, therefore, default to providing the Mongo instance, within the build, so they can be used as standalone instances.

Ideally, if the MONGO_URLenv variable is supplied, or MONGO=false is used, then we would not provide mongo. (normal production deployments would almost always have MONGO_URL provided).

This has been implemented and reverted before, and needs to be implemented and remain as a requirement (or some variation, perhaps another new image).

[aaronjudd]

See #1420

[saralouhicks]

I saw this error yesterday and today when trying to use Kitematic.

[aaronjudd]

Merged into marketplace but still needs merging to other branches @jshimko

[jshimko]

@aaronjudd Cherry pick PR's created for development (#2677) and master (#2678).

[aaronjudd]

@jshimko Should we close this? I'm not sure I want to pull #2678 into master, is it important to do so? if not let's close both.

[jshimko]

Assuming we don't want to merge those changes directly to master, yes, this is all set to close. The only reason I created #2678 was because this issue was specifically about being able to launch a container straight from Docker Hub (or with tools like Kitematic) without needing to setup/provide an external database. If that can wait until marketplace is merged, then we're good. That just means reactioncommerce/reaction:latest currently does not have Mongo installed in it until that time.

Want to make the call on that @aaronjudd?

[brent-hoover]

@aaronjudd @jshimko Can we close?

[jshimko]

Yes, this can be closed.

https://github.com/reactioncommerce/reaction/blob/master/.circleci/build.sh#L16