Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0.0] Update to Node 12 LTS version #5770

Closed
aldeed opened this issue Oct 30, 2019 · 2 comments
Closed

[3.0.0] Update to Node 12 LTS version #5770

aldeed opened this issue Oct 30, 2019 · 2 comments

Comments

@aldeed
Copy link
Contributor

aldeed commented Oct 30, 2019

  1. Make new prod and dev images in https://github.com/reactioncommerce/docker-base for the LTS (or higher) Node 12 version.
  2. Update .nvmrc, "engines" in package.json file, and the image tags in Dockerfile and docker-compose.yml all to the same matching Node 12 LTS version.
  3. Verify everything still works. I think they moved JSON import to be behind a flag so probably need to add that flag to our Node commands (see module: Revert remove experimental status from JSON modules nodejs/node#29754).
@aldeed
Copy link
Contributor Author

aldeed commented Dec 16, 2019

Waiting for https://nodejs.org/en/blog/vulnerability/december-2019-security-releases/

This was referenced Jan 14, 2020
Merged
Merged
@willopez
Copy link
Member

closed via #6029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willopez @aldeed