Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model class 'IdomModel' from module 'idom-client-jupyter' is loaded but can not be instantiated #24

Closed
rafaellichen opened this issue Dec 23, 2022 · 15 comments · Fixed by #25

Comments

@rafaellichen
Copy link

rafaellichen commented Dec 23, 2022

Launching binder notebook using the link from README results in the following error after executing cells.

[Open Browser Console for more detailed log - Double click to close this message]
Model class 'IdomModel' from module 'idom-client-jupyter' is loaded but can not be instantiated
TypeError: o._deserialize_state is not a function
    at u._make_model (https://hub.ovh2.mybinder.org/user/idom-team-idom-jupyter-lw0tbzbx/nbextensions/jupyter-js-widgets/extension.js?v=20221223025821:2:747339)

build logs:

Found built image, launching...
Launching server...
Server requested
2022-12-23T03:40:51.256234Z [Normal] Successfully assigned ovh2/jupyter-idom-2dteam-2didom-2djupyter-2d15jeanpl to user-202211a-node-c616e7
2022-12-23T03:40:52Z [Normal] Container image "jupyterhub/mybinder.org-tc-init:2020.12.4-0.dev.git.4289.h140cef5" already present on machine
2022-12-23T03:40:52Z [Normal] Created container tc-init
2022-12-23T03:40:52Z [Normal] Started container tc-init
2022-12-23T03:40:53Z [Normal] Pulling image "2lmrrh8f.gra7.container-registry.ovh.net/mybinder-builds/r2d-g5b5b759idom-2dteam-2didom-2djupyter-67cfe6:276e3ada3bcbff2f8254c2fa339ee3aeaf9b2b1e"
2022-12-23T03:41:46Z [Normal] Successfully pulled image "2lmrrh8f.gra7.container-registry.ovh.net/mybinder-builds/r2d-g5b5b759idom-2dteam-2didom-2djupyter-67cfe6:276e3ada3bcbff2f8254c2fa339ee3aeaf9b2b1e" in 53.041814721s
2022-12-23T03:41:46Z [Normal] Created container notebook
2022-12-23T03:41:47Z [Normal] Started container notebook
@rmorshea
Copy link
Contributor

Thanks for reporting this. There's been a lot of changes recently to idom and not all of them have made their way into idom-jupyter just yet. I suspect that's probably the cause.

@rafaellichen
Copy link
Author

rafaellichen commented Dec 23, 2022

Thanks for reporting this. There's been a lot of changes recently to idom and not all of them have made their way into idom-jupyter just yet. I suspect that's probably the cause.

@rmorshea thanks for the quick response. very strange behavior here.
launching through https://binder.mybinder.ovh/, resulting in https://hub-binder.mybinder.ovh/user/idom-team-idom-jupyter-exdbosus/lab, and the examples work.
launching through https://mybinder.org/, resulting in https://hub.ovh2.mybinder.org/user/idom-team-idom-jupyter-v38662cg/lab, and the examples don't work

image

image

@rmorshea
Copy link
Contributor

rmorshea commented Dec 23, 2022

That's very helpful information. Would have been very hard to find that out on my own.

If you open the debug console on your browser, do you get any interesting tracebacks?

@rafaellichen
Copy link
Author

rafaellichen commented Dec 23, 2022

If you open the debug console on your browser, do you get any interesting tracebacks?

no

@rmorshea
Copy link
Contributor

Maybe related: jupyterhub/mybinder.org-deploy#2407

@rmorshea
Copy link
Contributor

rmorshea commented Dec 23, 2022

For some reason when I launch through https://mybinder.org I end up with instances deployed at https://hub-binder.mybinder.ovh. However, when I deploy via https://ovh2.mybinder.org/ I get redirected to https://hub.ovh2.mybinder.org which, as you explain, results in errors.

@rmorshea
Copy link
Contributor

I have a draft PR to upgrade to the latest widget template and I see similar errors when I deploy that branch, even via https://mybinder.org. Hard to say exactly what's going on at the moment. Will keep digging when I find time though.

@rafaellichen
Copy link
Author

For some reason when I launch through https://mybinder.org I end up with instances deployed at https://hub-binder.mybinder.ovh. However, when I deploy via https://ovh2.mybinder.org/ I get redirected to https://hub.ovh2.mybinder.org which, as you explain, results in errors.

even when i use the same link https://binder.mybinder.ovh/ on this repository and my forked version (without changes), this repository works while my forked version results in same error. 😑

@rmorshea
Copy link
Contributor

rmorshea commented Dec 28, 2022

I'm unable to reproduce in ovh2 now. I'm also unable to reproduce when testing this out with repo2docker. I'm not really sure what to do here at the moment given that I'm no longer able to reproduce. Will close for now, but please comment if this persists.

@rafaellichen
Copy link
Author

rafaellichen commented Dec 28, 2022

@rmorshea can you verify this for me? thanks.
it doesn't work for me even though the code is the same. originally thought it could be js cache issue, but same problem persists under incognito mode.
https://mybinder.org/v2/gh/rafaellichen/idom-jupyter/276e3ada3bcbff2f8254c2fa339ee3aeaf9b2b1e?urlpath=lab%2Ftree%2Fnotebooks%2Fintroduction.ipynb

@rmorshea
Copy link
Contributor

Ok, I just double checked and I think I was looking at my open PR when testing things out. I can confirm that main is broken. However, my changes in #25 seem to fix things.

@rmorshea
Copy link
Contributor

I'll merge that PR and cut a release shortly.

@rmorshea
Copy link
Contributor

Ok, the PR has been merged. It would be great to get confirmation that everything works on your end before I do a release.

@rafaellichen
Copy link
Author

rafaellichen commented Dec 28, 2022

Ok, the PR has been merged. It would be great to get confirmation that everything works on your end before I do a release.

yes, can confirm it works even for my forked version of this repo now. thanks.

@rmorshea
Copy link
Contributor

idom-jupyter version 0.7.7 has been released! Let me know if you encounter any more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants