Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from flask-sockets to flask-sock #712

Closed
rmorshea opened this issue Mar 17, 2022 · 2 comments
Closed

Switch from flask-sockets to flask-sock #712

rmorshea opened this issue Mar 17, 2022 · 2 comments
Labels
priority-3-low May be resolved one any timeline. type-refactor About improving code structure.

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Mar 17, 2022

Current Situation

The flask-sockets has recently been archived. The project stopped being updated before Flask 2.0 so until we find another websockets solution for flask we're stuck with flask<2.

Proposed Actions

The flask-sock project seems like a promising replacement from the creator of the popular flask-socketio package. We should do some basic due diligence and then switch over to flask-sock. This will likely entail requiring flask>=2 for IDOM going forward.

@rmorshea rmorshea added flag-triage Not prioritized. priority-3-low May be resolved one any timeline. type-refactor About improving code structure. and removed flag-triage Not prioritized. labels Mar 17, 2022
@Archmonger
Copy link
Contributor

Archmonger commented Apr 16, 2022

Was this handled in the v0.38.0 release?

@nmz787-intel
Copy link

odd, flask-sockets is working for me with flask 2.0.2... I wonder if I had to hack on it to get it working, it's been >6 months since I first got it working in my proof-of-concept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low May be resolved one any timeline. type-refactor About improving code structure.
Projects
None yet
Development

No branches or pull requests

3 participants