Various warnings in React 16.13.1

[yunyu]

React version 16.13.1

Concurrent mode no

Describe the bug
React throws warnings when useResource is used anywhere:

Warning: Cannot update a component (`CacheProvider`) while rendering a different component (`PartnerRewards`). To locate the bad setState() call inside `PartnerRewards`, follow the stack trace as described in https://fb.me/setstate-in-render

[ntucker]

Thanks for the report!

"To locate the bad setState() call inside PartnerRewards, "

React seems to be suggesting the error is in PartnerRewards. I might be able to assist if the code is shared, but it most certainly is an interaction so hard to say what this is without being able to repro.

[yunyu]

Here is a barebones PartnerRewards that triggers the warning:

class PartnerRewardResource extends CMSResource {
  static urlRoot = `landing-page-partner-rewards/${SORT_BY_RANK}`;

  readonly id!: number;
  readonly company!: string;
  readonly blurb!: string;
  readonly website!: string;
  readonly logo!: Logo;
  readonly rank!: number;

  pk() {
    return this.id.toString();
  }
}

const PartnerRewards: React.FC<{}> = () => {
  const rewardsData = useResource(PartnerRewardResource.listShape(), {});

  return (
    <Box bg="gray4">{JSON.stringify(rewardsData)}</Box>
  );
};

CMSResource is just an extended copy of SimpleResource with a custom fetch - it doesn't touch React. If you have a public API demo to recommend, I may be able to make a repro project. However, this seems to affect every useResource call site.

[ntucker]

Thanks, was able to repro, looking into it!

[yunyu]

Appreciate it!

[ntucker]

Seems to be the call to fetch, but it seems odd that this would be a problem. I left a comment to get clarity in the react github: facebook/react#18178 (comment)

[ntucker]

Appears to be fixed in 4.5.9