Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveUI nuget package is incompatible with WinUI 3 (ARM64) #2657

Closed
huoyaoyuan opened this issue Jan 22, 2021 · 15 comments
Closed

ReactiveUI nuget package is incompatible with WinUI 3 (ARM64) #2657

huoyaoyuan opened this issue Jan 22, 2021 · 15 comments
Labels

Comments

@huoyaoyuan
Copy link

The same as dotnet/reactive#1461

It requires Microsoft.WindowsDesktop.App on net5.0-windows, which is unavailable on win-arm64. But WinUI 3 supports win-arm64.

I see System.Reactive.Linq.ControlObservable using Windows Forms. I wonder why it isn't in ReactiveUI.WinForms.

@huoyaoyuan huoyaoyuan added the bug label Jan 22, 2021
@glennawatson
Copy link
Contributor

We are unlikely to at the moment support WinUI 3 until it matures a bit more

@huoyaoyuan
Copy link
Author

You have packages for WPF and WinForms. Why not moving the framework-dependent members into them?

I know it's the not the time for supporting WinUI 3, but current package structure prevents any custom utilization.

@agent00jackson
Copy link

Any updates? MS is really pushing WinUI 3 now.

@glennawatson
Copy link
Contributor

I'll have another look in the coming weeks

One problem I had and others was they implemented INotifyPropertyChanged slightly different to most other platforms. Eg different namespaces etc

@kmgallahan
Copy link

Just commenting to add that this is a critical time for ReactiveUI to add support for WinUI 3.

I'm in that last boat. I had started to experiment with ReactiveUI in some LOB UWP projects 1-2 years ago, but after MS indicated UWP was dead and desktop is the way forward I put off further development. I'm starting back on up on the projects now and see that I have to make a choice to wait for ReactiveUI support or to proceed without it.

@glennawatson
Copy link
Contributor

@kmgallahan WinUI 3 is preview and we won't commit to any release of libraries against preview. We generally add support after the full release.

@huoyaoyuan
Copy link
Author

@glennawatson WinUI 3 is now supported with major version 0. It's not feature complete, but it's now supported.

The required action isn't to support anything specific to WinUI 3. It's a layering issue - System.Reactive shouldn't reference WinForms and only ReactiveUI.WinForms should.

@glennawatson
Copy link
Contributor

glennawatson commented Jun 6, 2021

Closing this issue for the moment due to a upcoming major release of RxUI.

@glennawatson
Copy link
Contributor

I am refactoring out the net4/net5 targets from the core RxUI project, but this might not work how you want given System.Reactive also includes Winforms/WPF dependencies in their project.

@huoyaoyuan
Copy link
Author

Yes, this is indeed a System.Reactive issue. But that issue isn't actively responded. It will be helpful if you can contact their maintainers.

@glennawatson
Copy link
Contributor

I don't have any influence over their maintainers.

@glennawatson
Copy link
Contributor

I will be removing the references to wpf and winforms in the main rxui nuget in a PR soon though.

That's mostly there for backwards compatibility for users due to the way Rx 5 did some stuff but can be moved into the wpf and winforms nugets.

WinUI3 is separate to this issue though and will make a separate issue to track so all those talking about winui this issue is related but not strictly related to it.

@FrancoisM
Copy link

"WinUI3 is separate to this issue though and will make a separate issue to track " => which separate issue @glennawatson please?

@glennawatson
Copy link
Contributor

Search the issues for winui3

We don't have plans to support until it's fully realised.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants