6.2.0 Causes "Don't know how to deal with Reset" on iOS

[thedillonb]

Just moved from 6.1.0 to 6.2.0 and noticed that all my Reactive Tables are having trouble due to an exception being thrown within https://github.com/reactiveui/ReactiveUI/blob/59aa7aedb5f8fa2ea644d810a8fa85f406234be7/ReactiveUI/Cocoa/CommonReactiveSource.cs on line 436. I believe this method is just be missing a "Reset" clause as much of ReactiveList triggers a Reset which would ultimiately cause problems here - unless, of course, I'm using something wrong.

[anaisbetts]

Paging @srimoyee-factory @tberman to the white courtesy ☎️

[thedillonb]

I enabled the debugger and dumped the logs around the event which might be helpful.

2014-11-10 20:36:17.261 CodeHubiOS[8866:70b] [Warn] - LogHost: SuppressChangeNotifications was called (perhaps via AddRange), yet you do not
2014-11-10 20:36:17.262 CodeHubiOS[8866:70b] [Warn] - LogHost: have a subscription to ShouldReset. This probably isn't what you want, as ItemsAdded
2014-11-10 20:36:17.262 CodeHubiOS[8866:70b] [Warn] - LogHost: and friends will appear to 'miss' items
2014-11-10 20:36:17.370 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: SectionInfo changed to ReactiveUI.TableSectionInformation`1[CodeHub.Core.ViewModels.Gists.GistItemViewModel][], resetup data and bindings...
2014-11-10 20:36:17.371 CodeHubiOS[8866:70b] [Warn] - CommonReactiveSource`4: New section info ReactiveUI.TableSectionInformation`1[CodeHub.Core.ViewModels.Gists.GistItemViewModel][] does not implement IReactiveNotifyCollectionChanged.
2014-11-10 20:36:17.379 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: Done resetuping all bindings!
2014-11-10 20:36:17.386 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: SectionInfo about to change, disposing all bindings...
2014-11-10 20:36:17.387 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: SectionInfo changed to ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][], resetup data and bindings...
2014-11-10 20:36:17.387 CodeHubiOS[8866:70b] [Warn] - CommonReactiveSource`4: New section info ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][] does not implement IReactiveNotifyCollectionChanged.
2014-11-10 20:36:17.390 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: Done resetuping all bindings!
2014-11-10 20:36:17.393 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: NumberOfSections: 1 (from ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][])
2014-11-10 20:36:17.399 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: RowsInSection: 0-0 (from ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][] / ReactiveUI.ReactiveDerivedCollection`2[GitHubSharp.Models.GistModel,CodeHub.Core.ViewModels.Gists.GistItemViewModel])
2014-11-10 20:36:17.426 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][] is changed, resetup section data and bindings...
2014-11-10 20:36:17.427 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: Setting up section 0 binding...
2014-11-10 20:36:17.430 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: Done resetuping section data and bindings!
2014-11-10 20:36:17.430 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: Calling ReloadData()...
2014-11-10 20:36:17.431 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: NumberOfSections: 1 (from ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][])
2014-11-10 20:36:17.431 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: RowsInSection: 0-0 (from ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][] / ReactiveUI.ReactiveDerivedCollection`2[GitHubSharp.Models.GistModel,CodeHub.Core.ViewModels.Gists.GistItemViewModel])
2014-11-10 20:36:17.681 CodeHubiOS[8866:70b] [Warn] - LogHost: SuppressChangeNotifications was called (perhaps via AddRange), yet you do not
2014-11-10 20:36:17.681 CodeHubiOS[8866:70b] [Warn] - LogHost: have a subscription to ShouldReset. This probably isn't what you want, as ItemsAdded
2014-11-10 20:36:17.682 CodeHubiOS[8866:70b] [Warn] - LogHost: and friends will appear to 'miss' items
2014-11-10 20:36:17.695 CodeHubiOS[8866:70b] [Debug] - CommonReactiveSource`4: Changed contents: [Reset] (from ReactiveUI.TableSectionInformation`2[CodeHub.Core.ViewModels.Gists.GistItemViewModel,MonoTouch.UIKit.UITableViewCell][])

[srimoyee-factory]

@paulcbetts looking at it.
@thedillonb what causes this error? I tried loading a reactive table and adding rows to it, didn't see any issues with that.

[anaisbetts]

@srimoyee-factory Try calling Reset on your collection

[srimoyee-factory]

Sorry about that, just requested a pull request #755

[thedillonb]

Thanks for the quick turn around guys!

[srimoyee-factory]

@paulcbetts can you do a new 6.2.1 build with this fix. I created an issue #760. Thanks.

[anaisbetts]

@srimoyee-factory I'll work on this at the weekend, yeah

[srimoyee-factory]

@paulcbetts thanks