Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of alternative (JSON / De-)Serializers #106

Closed
joergbattermann opened this issue Dec 20, 2014 · 2 comments
Closed

Usage of alternative (JSON / De-)Serializers #106

joergbattermann opened this issue Dec 20, 2014 · 2 comments
Labels

Comments

@joergbattermann
Copy link

Good morning,

I just started playing with refit and I was wondering whether it was possible to use an alternative Json serializer and deserializer than Json.Net? As far as I can see it its hard-wired mostly in RequestBuilderImplementation.cs, but I've come to love Jil, been using NetJson in another project and some might use protobuf, MessagePack or some other formats.

While those might not provide support for the exact same amount of platforms as refit does, it might be nice to have a choice and I was wondering, whether the hard-coded usage of Json.net could be de-coupled and one could provide custom (de)serialization providers for refit?

Basically something like providing a Serializer registration point in https://github.com/paulcbetts/refit/blob/master/Refit/RefitSettings.cs, use that one instead of Json.Net directly?

I've forked away refit and started dabbling with this idea but wanted to check upfront whether this is something you might be ok with?

Cheers,
-J

@clairernovotny
Copy link
Member

This is likely in-line with #75, so from a generic standpoint the thinking seems to be more about providing a custom serialization mechanism of any kind per type/method, etc.

@joergbattermann
Copy link
Author

@onovotny Ahh yeah #75 and #83 are exactly what I had in mind. I'll close this issue here, keep an eye on the other two and once these make their way into refit & one can write custom serializers for, I'll do just that.

Thanks for pointing me in the right direction!

@lock lock bot added the outdated label Jun 25, 2019
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants