Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object.setPrototypeOf not available in IE10 #3966

Closed
benlesh opened this issue Jul 27, 2018 · 0 comments · Fixed by #3967 or severest/retrobot#221
Closed

Object.setPrototypeOf not available in IE10 #3966

benlesh opened this issue Jul 27, 2018 · 0 comments · Fixed by #3967 or severest/retrobot#221
Assignees
@benlesh

Comments

@benlesh
Copy link
Member

benlesh commented Jul 27, 2018

As of RxJS 6, partners like Angular are having a hard time with IE10 because we are using Object.setPrototypeOf in our Error classes.

Related: angular/angular#24488
@benlesh benlesh self-assigned this Jul 27, 2018
benlesh added a commit to benlesh/rxjs that referenced this issue Jul 28, 2018
@benlesh
fix(IE10): Remove dependency on Object.setPrototypeOf
7279f06 
This reimplements all Error types as ES5 classes, and types them with TypeScript such that
we no longer need to rely on Object.setPrototypeOf, which was causing issues for users who had not
polyfilled it properly in IE10.

fixes ReactiveX#3966
@benlesh benlesh mentioned this issue Jul 28, 2018
Merged
benlesh added a commit to benlesh/rxjs that referenced this issue Jul 28, 2018
@benlesh
fix(IE10): Remove dependency on Object.setPrototypeOf
08326ea 
This reimplements all Error types as ES5 classes, and types them with TypeScript such that
we no longer need to rely on Object.setPrototypeOf, which was causing issues for users who had not
polyfilled it properly in IE10.

fixes ReactiveX#3966
benlesh added a commit that referenced this issue Jul 28, 2018
@benlesh
fix(IE10): Remove dependency on Object.setPrototypeOf (#3967)
5c52a73 
This reimplements all Error types as ES5 classes, and types them with TypeScript such that
we no longer need to rely on Object.setPrototypeOf, which was causing issues for users who had not
polyfilled it properly in IE10.

fixes #3966
@mhevery mhevery mentioned this issue Jul 31, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benlesh benlesh

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@benlesh