-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TestScheduler): Add subscription schedule to expectObservable #3997
Conversation
Could you please describe the use cases and motivation for the change? This isn't anything that has been considered or discussed on the team, so my immediate concern is that there isn't a need for it. Giving us concrete examples of where it's a useful feature will help us decide what we should do here. |
An example use would be to test shareReplay.
would be rewritten to something like this
|
@gstamac That's a great example! I'll add this to our core team agenda so we can discuss it. Thanks! |
#4006 fixes the travis issue. |
Thanks, @gstamac! Good addition! |
Description:
I made this PR (#3429) already for the previous version but was rejected because of API changes. Now the new API is here and I'm making the same PR.
Related issue (if exists): #3429