Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): remove internal from import locations #4498

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jan 27, 2019

Description:

This PR fixes the problem reported in #4070 by removing internal from the import locations within compat/Observable.ts. Note that no other import locations within compat include internal.

For more information:

  • this comment shows the commit that introduced the problem; and
  • this comment explains how the problem is effected in Angular-CLI projects.

Related issue (if exists): #4070

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7958

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.813%

Totals Coverage Status
Change from base Build 7954: 0.0%
Covered Lines: 5256
Relevant Lines: 5429

💛 - Coveralls

@cartant cartant requested a review from benlesh January 27, 2019 11:09
@benlesh benlesh merged commit a6c0017 into ReactiveX:master Jan 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
@cartant cartant deleted the issue-4070 branch September 24, 2020 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants