Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-app): remove stopWordFilter from lunr pipeline #4536

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

flakolefluk
Copy link
Contributor

Description:
This PR removes the stopWordFilter from the lunr pipeline. It filters words like "of" and "from" when indexing, missing some operators or functions when searching.

https://github.com/olivernn/lunr.js/blob/master/lib/stop_word_filter.js

Related issue (if exists):
Fixes #4524

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8062

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.962%

Files with Coverage Reduction New Missed Lines %
src/internal/observable/fromPromise.ts 1 87.5%
src/internal/observable/fromIterable.ts 2 95.24%
src/internal/observable/fromObservable.ts 2 83.33%
Totals Coverage Status
Change from base Build 8053: 0.2%
Covered Lines: 5777
Relevant Lines: 5958

💛 - Coveralls

@niklas-wortmann
Copy link
Member

I need to test that manually very quick. I'll do my best to do it asap. I'll let you know. But thanks for contributing!

Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow well spotted. It works great!

@flakolefluk
Copy link
Contributor Author

awesome! thanks for reviewing it :)

@ladyleet
Copy link
Member

hi @flakolefluk !!!!!!

@ladyleet
Copy link
Member

hey @jwo719 @benlesh - @flakolefluk is joining our team next week!

@benlesh benlesh merged commit 9eaebd4 into ReactiveX:master Feb 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants