Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race typings broken for mixed observable types in 6.4.0 #4642

Closed
benlesh opened this issue Mar 15, 2019 · 0 comments · Fixed by #4643
Closed

race typings broken for mixed observable types in 6.4.0 #4642

benlesh opened this issue Mar 15, 2019 · 0 comments · Fixed by #4643
Assignees
@benlesh
Labels
bug Confirmed bug

Comments

@benlesh
Copy link
Member

benlesh commented Mar 15, 2019

Bug Report

Current Behavior
Subscribing to the result of a race of two different types of observables results in a type error.

Reproduction
stackblitz

Expected behavior
It shouldn't error.

Environment

  • RxJS version: 6.4.0

Possible Solution
Fix the types to not be Observable<string> | Observable<number> and be Observable<string | number>
@benlesh benlesh added the bug Confirmed bug label Mar 15, 2019
@benlesh benlesh self-assigned this Mar 15, 2019
benlesh added a commit to benlesh/rxjs that referenced this issue Mar 15, 2019
@benlesh
fix(race): better typings
a3630e1 
- Actually accept other `ObservableInput` types (Promises, etc)
- Fixes issue where TypeScript would complain when you tried to subscribe to a race between to Observable types.

Fixes ReactiveX#4390
Fixes ReactiveX#4642
@benlesh benlesh mentioned this issue Mar 15, 2019
Merged
benlesh added a commit that referenced this issue Mar 15, 2019
@benlesh
fix(race): better typings (#4643)
fb9bc48 
- Actually accept other `ObservableInput` types (Promises, etc)
- Fixes issue where TypeScript would complain when you tried to subscribe to a race between to Observable types.

Fixes #4390
Fixes #4642
@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
BioPhoton pushed a commit to BioPhoton/rxjs that referenced this issue May 15, 2019
@benlesh @BioPhoton
fix(race): better typings (ReactiveX#4643)
06f9183 
- Actually accept other `ObservableInput` types (Promises, etc)
- Fixes issue where TypeScript would complain when you tried to subscribe to a race between to Observable types.

Fixes ReactiveX#4390
Fixes ReactiveX#4642
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benlesh benlesh

Labels
bug Confirmed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(race): better typings benlesh/rxjs
1 participant
@benlesh