feat(rxjs-compat): removed for v7 #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `rxjs/Rx` is no longer a valid import site. BREAKING CHANGE: `rxjs-compat` is not published for v7 (yet)
cartant
approved these changes
Jun 9, 2019
| @@ -222,8 +198,5 @@ | |||
| "engines": { | |||
| "npm": ">=2.0.0" | |||
| }, | |||
| "typings": "./dist/package/Rx.d.ts", | |||
There was a problem hiding this comment.
If rxjs/Rx is no longer a valid import, is ./dist/package/Rx.d.ts going to be were the types are?
There was a problem hiding this comment.
Hmmm... that's a good question. I think we're going to need to take another pass through the module settings in package.json to ensure we're going about this right. We have have a little time, we just need to sort it out before the first alpha release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all files that were solely related to v6 backward compatibility with v5, and/or related to schematic migration from v5 to v6.
Note that there were some changes required to tsconfig files based off of changes to the build process (in order to stop building compatibility related files)
BREAKING CHANGE:
rxjs/Rxis no longer a valid import site.BREAKING CHANGE:
rxjs-compatis not published for v7 (yet)