Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support N args in static race and ensure observable returned #5286

Merged
merged 4 commits into from
Feb 7, 2020
Merged

fix: support N args in static race and ensure observable returned #5286

merged 4 commits into from
Feb 7, 2020

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jan 31, 2020

Description:

This PR:

  • Adds a failing test and fixes a bug in the static race implementation in which a single ObservableInput argument was returned without from being called upon it to ensure that an Observable was returned.
  • Adds support for N args to the static race types.

Related issue: None

@cartant cartant requested a review from benlesh January 31, 2020 21:26
@benlesh benlesh merged commit 6d901cb into ReactiveX:master Feb 7, 2020
martinsik pushed a commit to martinsik/rxjs that referenced this pull request Feb 15, 2020
@cartant
fix: support N args in static race and ensure observable returned (Re…
19db222 
…activeX#5286)

* test: add failing test for race

* fix: use from on ObservableInput

* fix: support N args for static race

* chore: use dtslint helpers
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
@cartant cartant deleted the race-n-args branch September 24, 2020 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh Awaiting requested review from benlesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cartant @benlesh