fix(repeat): Ensure teardown happens between repeated synchronous obs… #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervables - Simplifies repeat code - Removes reliance on unsubscribeAndRecycle - Gets rid of strange, undocumented behavior where numbers less than zero were treated like positive infinity - Fixes an issue where `finalize` would be called N times after the completion of the resulting observable if the source was synchronous. - Fixes an issue where N unsubscriptions would always occur after the total completion. BREAKING CHANGE: An undocumented behavior where passing a negative count argument to `repeat` would result in an observable that repeats forever.
|
I seriously considered removing I suspect that |
benlesh
added a commit
to benlesh/rxjs
that referenced
this pull request
Aug 3, 2020
…onous observables Related: ReactiveX#5620 - Resolves an issue where all teardowns would not execute until the result observable was complete if the source was synchronous BREAKING CHANGE: Removed an undocumented behavior where passing a negative count argument to `retry` would result in an observable that repeats forever.
This was referenced Aug 3, 2020
cartant
reviewed
Aug 4, 2020
| if (++soFar < count) { | ||
| if (innerSub) { | ||
| subscription.remove(innerSub); | ||
| innerSub.unsubscribe(); |
There was a problem hiding this comment.
Is there a reason innerSub is not nulled here?
I think that if it isn't, there will be a problem if the source is async on the first subscription and sync on a subsequent subscription - as innerSub won't be null for the subsequent completion, despite that completion being synchronous.
There was a problem hiding this comment.
nope... just didn't think of it. Also, that remove is superfluous, teh unsubscribe will do that...
cartant
approved these changes
Aug 4, 2020
benlesh
added a commit
to benlesh/rxjs
that referenced
this pull request
Aug 5, 2020
…onous observables Related: ReactiveX#5620 - Resolves an issue where all teardowns would not execute until the result observable was complete if the source was synchronous BREAKING CHANGE: Removed an undocumented behavior where passing a negative count argument to `retry` would result in an observable that repeats forever.
benlesh
added a commit
that referenced
this pull request
Aug 6, 2020
…onous observables Related: #5620 - Resolves an issue where all teardowns would not execute until the result observable was complete if the source was synchronous BREAKING CHANGE: Removed an undocumented behavior where passing a negative count argument to `retry` would result in an observable that repeats forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ervables
finalizewould be called N times after the completion of the resulting observable if the source was synchronous.BREAKING CHANGE: Removed an undocumented behavior where passing a negative count argument to
repeatwould result in an observable that repeats forever.