fix: useDeprecatedSynchronousErrorThrowing honored for flattened sync sources #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
commented
Jan 26, 2021
| // do it's magic in the `_next`, `_error`, and `_complete` methods. | ||
| this.destination = { | ||
| next: next ? maybeWrapForDeprecatedSyncErrorHandling(next, this) : noop, | ||
| error: maybeWrapForDeprecatedSyncErrorHandling(error ? error : defaultErrorHandler, this), |
There was a problem hiding this comment.
The meat of the change is here.
benlesh
commented
Jan 26, 2021
| // If we don't have arguments, or the observer passed is already EMPTY_OBSERVER, | ||
| // use EMPTY_OBSERVER. This is just to save a little on object allocations. | ||
| this.destination = EMPTY_OBSERVER; | ||
| if ((observerOrNext || error || complete) && observerOrNext !== EMPTY_OBSERVER) { |
There was a problem hiding this comment.
After some thought, I realized that this check, and setting this.destination = EMPTY_OBSERVER was pointless, so that got removed.
It might be better to review this with "ignore whitespace" on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5983