fix(distinctUntilChanged): Ensure reentrant code is compared properly #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes an issue where reentrant code would not be compared properly against previous emissions - Adds better code comments - Updates documentation with better text and examples
benlesh
commented
Feb 10, 2021
| subscriber.next(value); | ||
| } | ||
| prev = key; | ||
| first = false; |
There was a problem hiding this comment.
These can't happen after we next, it has to happen before. Otherwise the added test will fail.
benlesh
commented
Feb 10, 2021
| // We've been allowing `null` do be passed as the `compare`, so we can't do | ||
| // a default value for the parameter, because that will only work | ||
| // for `undefined`. | ||
| comparator = comparator ?? defaultCompare; |
There was a problem hiding this comment.
Added this comment, because I tried to use a default value parameter here and it was sad. We should probably deprecate this sort of thing at some point, and make this a configuration object, I suppose.
cartant
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6013