fix: forkJoin POJO signature should match only ObservableInput values #6095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR tightens the
forkJoin
POJO signature so that only POJOs withObservableInput
values are matched. The implementation throws if the received POJO contains a value that is not anObservableInput
, so the types should reflect that.As an aside, we should look at renaming some of our utility types, as the
ObservableValueTuple
type is mapped type that's not restricted to tuples. It could be used in this signature, too:But having
Tuple
in the type name makes no sense here. We can do this later, after v7, and can deprecate the old names (which have been exported).Related issue (if exists): Nope