-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fromEvent() type with resultSelector #6447
Conversation
This change affects the public API, so the |
@cartant Thanks for the reminder! The |
I've had a closer look at the dtslint tests to see why this wasn't picked up. We should add two tests similar to these and should include the options argument so that those signatures are tested: FYI, the dtslint tests are run using |
Good call. I've added 4 more dtslint tests there for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Description:
This PR simply fixes the return type of one overloaded form of
fromEvent()
that accepts aresultSelector
.With a
resultSelector: (event: T) => R
,fromEvent<T, R>
should return aObservable<R>
, instead ofObservable<T>
.Related issue (if exists): N/A