(Likely) Scheduled action leaks

[cartant]

It seems likely to me that some - if not all - of the following scheduler.schedule calls will leak actions that are added to another subscription - similar to the leak that was fixed in #6559:

rxjs/src/internal/observable/combineLatest.ts

Line 296 in 5d0e41e

subscription.add(scheduler.schedule(execute));

rxjs/src/internal/operators/bufferTime.ts

Line 120 in 5d0e41e

subs.add(scheduler.schedule(() => emit(record), bufferTimeSpan));

rxjs/src/internal/operators/bufferTime.ts

Lines 128 to 133 in 5d0e41e

	subscriber.add(
	scheduler.schedule(function () {
	startBuffer();
	!this.closed && subscriber.add(this.schedule(null, bufferCreationInterval));
	}, bufferCreationInterval)
	)

rxjs/src/internal/operators/mergeInternals.ts

Line 117 in 5d0e41e

innerSubScheduler ? subscriber.add(innerSubScheduler.schedule(() => doInnerSub(bufferedValue))) : doInnerSub(bufferedValue);

rxjs/src/internal/operators/windowTime.ts

Line 139 in 5d0e41e

subs.add(scheduler.schedule(() => closeWindow(record), windowTimeSpan));

rxjs/src/internal/operators/windowTime.ts

Lines 147 to 152 in 5d0e41e

	subscriber.add(
	scheduler.schedule(function () {
	startWindow();
	!this.closed && subscriber.add(this.schedule(null, windowCreationInterval));
	}, windowCreationInterval)
	)

rxjs/src/internal/scheduled/scheduleAsyncIterable.ts

Lines 11 to 25 in 5d0e41e

	sub.add(
	scheduler.schedule(() => {
	const iterator = input[Symbol.asyncIterator]();
	sub.add(scheduler.schedule(function () {
	iterator.next().then(result => {
	if (result.done) {
	subscriber.complete();
	} else {
	subscriber.next(result.value);
	this.schedule();
	}
	});
	}));
	})
	);

rxjs/src/internal/scheduled/scheduleObservable.ts

Lines 9 to 16 in 5d0e41e

	sub.add(scheduler.schedule(() => {
	const observable: Subscribable<T> = (input as any)[Symbol_observable]();
	sub.add(observable.subscribe({
	next(value) { sub.add(scheduler.schedule(() => subscriber.next(value))); },
	error(err) { sub.add(scheduler.schedule(() => subscriber.error(err))); },
	complete() { sub.add(scheduler.schedule(() => subscriber.complete())); },
	}));
	}));

rxjs/src/internal/scheduled/schedulePromise.ts

Lines 9 to 14 in 5d0e41e

	subscriber.add(
	scheduler.schedule(() => {
	subscriber.next(value);
	subscriber.add(scheduler.schedule(() => subscriber.complete()));
	})
	);

rxjs/src/internal/util/caughtSchedule.ts

Lines 11 to 18 in 5d0e41e

	const subscription = scheduler.schedule(function () {
	try {
	execute.call(this);
	} catch (err) {
	subscriber.error(err);
	}
	}, delay);
	subscriber.add(subscription);

Some of these might leak only a few actions, but any leaked actions will have a closure that could be referencing a resource.

@benlesh

[benlesh]

I have some plans for this I think. 🤔