Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

v2: support horizontalBar chart #115

Open
ghost opened this issue May 20, 2016 · 3 comments
Open

v2: support horizontalBar chart #115

ghost opened this issue May 20, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented May 20, 2016

Chart.js supports horizontalBar charts as of lately, see:
http://jsfiddle.net/3xts05xu/

But it's impossible to pass horizontalBar type, because type gets lowercased on this line:
https://github.com/jhudson8/react-chartjs/blob/chartjs-v2/lib/core.js#L76

What is the purpose behind .lowercase()?
Wouldn't it be better to allow to pass any type and leave it up to chart js to throw error?

@OddEssay
Copy link

I put a PR #122 that addresses this.

@ghost
Copy link
Author

ghost commented Jun 23, 2016

@OddEssay
Great work 👍

@ledsun ledsun mentioned this issue Jun 26, 2016
@ramimazid
Copy link

@OddEssay How do you get HorizontalBar to work in your branch? It returns undefined when I reference it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants