ignore ObjectMethod

Author: danez

packages/react-docgen/src/utils/__tests__/getMemberExpressionValuePath-test.ts

@@ -1,6 +1,8 @@
+import type { ObjectMethod, VariableDeclaration } from '@babel/types';
 import { parse } from '../../../tests/utils';
 import getMemberExpressionValuePath from '../getMemberExpressionValuePath.js';
 import { describe, expect, test } from 'vitest';
+import type { NodePath } from '@babel/traverse';
 
 describe('getMemberExpressionValuePath', () => {
   describe('MethodExpression', () => {
@@ -101,4 +103,23 @@ describe('getMemberExpressionValuePath', () => {
       );
     });
   });
+  describe('ObjectMethod', () => {
+    test('ignores ObjectMethod', () => {
+      const def = parse.statement<VariableDeclaration>(`
+        const slice = createSlice({
+          example(state, action) {
+          },
+        });
+      `);
+
+      // path to `action.payload.id`
+      const path = def
+        .get('declarations')[0]
+        .get('init')
+        .get('arguments')[0]
+        .get('properties')[0] as NodePath<ObjectMethod>;
+
+      expect(getMemberExpressionValuePath(path, 'images')).toBe(null);
+    });
+  });
 });

packages/react-docgen/src/utils/getMemberExpressionValuePath.ts

@@ -37,6 +37,12 @@ function resolveName(path: NodePath): string | undefined {
     return;
   }
 
+  // When we check ObjectMethod we simply ignore it as assigning
+  // to it is technicaly possible but rare
+  if (path.isObjectMethod()) {
+    return;
+  }
+
   if (
     path.isFunctionExpression() ||
     path.isArrowFunctionExpression() ||
@@ -63,16 +69,6 @@ function resolveName(path: NodePath): string | undefined {
     return;
   }
 
-  if (path.isObjectMethod()) {
-    const key = path.get('key');
-
-    if (key.isIdentifier()) {
-      return key.node.name;
-    }
-
-    return;
-  }
-
   throw new TypeError(
     'Attempted to resolveName for an unsupported path. resolveName does not accept ' +
       path.node.type +