Add support for TSAsExpressions when trying to stringify expressions #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a combination of forwardRefs and generics leads to wanting to use type assertions to retain the generic nature of the wrapped class. This plays rather poorly with propTypes. After a lot of mucking around I decided to simply assert the desired type when setting propTypes and defaults.
This leads to code like this:
```tsx
(MenuItem as ComponentObjectOf<typeof MenuItem>).propTypes - {...}
```
This change extends expressionTo.toArray to deal with the typescript expression.
danez
approved these changes
Jul 2, 2022
danez
pushed a commit
that referenced
this pull request
Jul 2, 2022
…ions (#634) Using a combination of forwardRefs and generics leads to wanting to use type assertions to retain the generic nature of the wrapped class. This plays rather poorly with propTypes. After a lot of mucking around I decided to simply assert the desired type when setting propTypes and defaults. This leads to code like this: ```tsx (MenuItem as ComponentObjectOf<typeof MenuItem>).propTypes - {...} ``` This change extends expressionTo.toArray to deal with the typescript expression. Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com> # Conflicts: # src/__tests__/__snapshots__/main-test.js.snap # src/utils/__tests__/expressionTo-test.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a combination of forwardRefs and generics leads to wanting to use type assertions to retain the generic nature of the wrapped class. This plays rather poorly with propTypes. After a lot of mucking around I decided to simply assert the desired type when setting propTypes and defaults.
This leads to code like this:
This change extends expressionTo.toArray to deal with the typescript expression.