Performance for dynamic and heavy modal content

[murugaratham]

Summary:

Steps to reproduce:

1. Created an array of objects to be loaded after openModal is triggered
2. I did a .Map and return ~100 items
3. On desktop, the delay is 2-3s

Expected behavior:

Opening and closing modal should not rerender/update modal content

Additional notes:

Can add a prop to disable shouldComponentUpdate?

[diasbruno]

@murugaratham hmm,...maybe you can extend the Modal and use shouldComponentUpdate.

class MyModal extends Modal {
  shouldComponentUpdate() { ... }
}

[diasbruno]

@murugaratham is the patch above solves your issue or did you found out another way?

[alex-shamshurin]

The same is here - with react-datepicker it's very slow. Especially on mobiles.

[diasbruno]

Hi @alex-shamshurin, can you provide more info about this?

[diasbruno]

Can you provide a reproducible example of your problem?

[alex-shamshurin]

Sorry, I discovered a problem is in react-datepicker itself (in my configuration).

[diasbruno]

Ok. Thanks @alex-shamshurin.