Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactUJS Clientside should ReactDom.hydrate #808

Closed
1 of 4 tasks
BookOfGreg opened this issue Oct 16, 2017 · 3 comments
Closed
1 of 4 tasks

ReactUJS Clientside should ReactDom.hydrate #808

BookOfGreg opened this issue Oct 16, 2017 · 3 comments

Comments

@BookOfGreg
Copy link
Member

Help us help you! Please choose one:

  • My app crashes with react-rails, so I've included the stack trace and the exact steps which make it crash.
  • My app doesn't crash, but I'm getting unexpected behavior. So, I've described the unexpected behavior and suggested a new behavior.
  • I'm trying to use react-rails with another library, but I'm having trouble. I've described my JavaScript management setup (eg, Sprockets, Webpack...), how I'm trying to use this other library, and why it's not working.
  • I have another issue to discuss.

React 16 on master has deprecation warnings for React 17 about hydrate

https://reactjs.org/blog/2017/09/26/react-v16.0.html#new-deprecations

@rmosolgo
Copy link
Member

Interesting, I guess it fix some edge cases about re-rendering into different HTML facebook/react#10339

@BookOfGreg
Copy link
Member Author

BookOfGreg commented Nov 3, 2017

Wow, @rmosolgo was just testing this on my company's project and it makes the whole thing WAY faster!
Excited about this change.

@rmosolgo
Copy link
Member

rmosolgo commented Nov 3, 2017

🤘 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants