Skip to content

Add more CIs (Rails 5.2, Webpacker v4 pre) #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
ttanimichi opened this issue Aug 6, 2018 · 4 comments · Fixed by #934
Closed
2 tasks done

Add more CIs (Rails 5.2, Webpacker v4 pre) #918

ttanimichi opened this issue Aug 6, 2018 · 4 comments · Fixed by #934

Comments

@ttanimichi
Copy link
Member

ttanimichi commented Aug 6, 2018 •
edited by BookOfGreg
Loading

  • Against Rails 5.2 and Webpacker v3
  • Against Webpacker v4 pre (allow_failures)
@BookOfGreg BookOfGreg mentioned this issue Sep 15, 2018
Merged
@ttanimichi ttanimichi changed the title Add more CIs Add more CIs (Rails 5.2, Webpacker v4 pre) Oct 4, 2018
@ttanimichi ttanimichi mentioned this issue Oct 4, 2018
Closed
@zucler
Copy link

zucler commented Jan 3, 2019

Hi there, has there been any progress on this? It would be great if you guys could add Webpacker 4.x support. Thanks in advance!

@BookOfGreg
Copy link
Member

@zucler Webpacker hasn't properly released it's v4 in line with Webpack's v4 so I wasn't in a rush to get this out. I'll update the version of Webpacker to 4.0.0.rc.2 and see if it runs anyway. Our test suite is a little sensitive so will have to see if it can update cleanly or not.
#934

@petevk
Copy link

petevk commented Mar 4, 2019

Hey there, I'm not sure if this was blocked on a stable release of webpacker v4, but as of a few minutes ago it's been released.

@StanBright
Copy link

StanBright commented Mar 15, 2019 •
edited
Loading

For the record, I just upgraded https://www.saashub.com to use webpacker 4 and it seems to work fine with react-rails (2.4.7) 🎉

@0xdevalias 0xdevalias mentioned this issue Apr 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore/update appraisals reactjs/react-rails
5 participants
@StanBright @BookOfGreg @zucler @petevk @ttanimichi