Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Add new type for custom tabs function components #469

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

danez
Copy link
Collaborator

@danez danez commented Apr 17, 2022

Fixes #333

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #469 (1c0fe12) into main (4e3eff1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files           9        9           
  Lines         328      328           
  Branches      104      104           
=======================================
  Hits          325      325           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3eff1...1c0fe12. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 17, 2022

📊 Package size report   0.1%↑

File Before (Size / Gzip) After (Size / Gzip)
index.d.ts 1.8 kB / 485 B 8%↑1.9 kB / 9%↑529 B
README.md 12.7 kB / 3.9 kB 0.9%↑12.8 kB / 0.8%↑3.9 kB
Total (Includes all files) 199.3 kB / 61.0 kB 0.1%↑199.6 kB / 0.1%↑61.1 kB
Tarball size 45.8 kB 0.2%↑45.9 kB
Unchanged files
File Size (Size / Gzip)
dist/react-tabs.development.js 19.7 kB / 4.8 kB
dist/react-tabs.production.min.js 7.3 kB / 2.6 kB
esm/components/Tab.js 2.1 kB / 845 B
esm/components/TabList.js 1.1 kB / 497 B
esm/components/TabPanel.js 1.5 kB / 651 B
esm/components/Tabs.js 3.1 kB / 1.1 kB
esm/components/UncontrolledTabs.js 7.1 kB / 2.0 kB
esm/helpers/childrenDeepMap.js 877 B / 307 B
esm/helpers/count.js 213 B / 157 B
esm/helpers/elementTypes.js 254 B / 145 B
esm/helpers/propTypes.js 2.6 kB / 921 B
esm/index.js 200 B / 94 B
lib/components/Tab.js 3.6 kB / 1.3 kB
lib/components/TabList.js 1.4 kB / 585 B
lib/components/TabPanel.js 1.9 kB / 742 B
lib/components/Tabs.js 4.6 kB / 1.5 kB
lib/components/UncontrolledTabs.js 8.8 kB / 2.4 kB
lib/helpers/childrenDeepMap.js 1.1 kB / 353 B
lib/helpers/count.js 333 B / 195 B
lib/helpers/elementTypes.js 406 B / 196 B
lib/helpers/propTypes.js 2.8 kB / 973 B
lib/index.js 582 B / 220 B
LICENSE 1.1 kB / 646 B
package.json 3.5 kB / 1.3 kB
src/components/Tab.js 1.9 kB / 691 B
src/components/TabList.js 670 B / 326 B
src/components/TabPanel.js 1.1 kB / 491 B
src/components/Tabs.js 4.2 kB / 1.5 kB
src/components/UncontrolledTabs.js 11.0 kB / 3.0 kB
src/helpers/childrenDeepMap.js 1.4 kB / 441 B
src/helpers/count.js 250 B / 176 B
src/helpers/elementTypes.js 269 B / 156 B
src/helpers/propTypes.js 3.3 kB / 1.0 kB
src/index.js 224 B / 100 B
style/react-tabs.css 842 B / 369 B
style/react-tabs.less 879 B / 393 B
style/react-tabs.scss 879 B / 393 B
Hidden files
File Before (Size / Gzip) After (Size / Gzip)
dist/react-tabs.development.js.map 49.6 kB / 13.6 kB 49.6 kB / 13.6 kB
dist/react-tabs.production.min.js.map 32.4 kB / 9.5 kB 32.4 kB / 9.5 kB

🤖 This report was automatically generated by pkg-size-action

@danez danez merged commit f5a877c into main Apr 17, 2022
@danez danez deleted the danez-patch-1 branch April 17, 2022 16:09
@github-actions
Copy link

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom function components and TypeScript
2 participants