Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow disable left right buttons #504

Merged
merged 2 commits into from
Nov 27, 2022
Merged

feat: Allow disable left right buttons #504

merged 2 commits into from
Nov 27, 2022

Conversation

dpkrolak
Copy link
Contributor

Currently only up/down buttons can be disabled. This pr adds possibility to disable left/right buttons as well which is helpful for vertical tabs.

@danez danez self-requested a review November 27, 2022 12:14
@codecov-commenter
Copy link

Codecov Report

Merging #504 (60c3f14) into main (b3f77c7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files           9        9           
  Lines         328      328           
  Branches      104      104           
=======================================
  Hits          325      325           
  Misses          3        3           
Impacted Files Coverage Δ
src/components/Tabs.js 100.00% <ø> (ø)
src/components/UncontrolledTabs.js 99.40% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danez danez merged commit ed49912 into reactjs:main Nov 27, 2022
@danez
Copy link
Collaborator

danez commented Nov 27, 2022

Thanks, that makes totally sense,

@github-actions
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants