Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Omission]: useOptimistic is documented as having a required second parameter #7098

Open
denis-sokolov opened this issue Aug 8, 2024 · 1 comment · May be fixed by #7109
Open

[Omission]: useOptimistic is documented as having a required second parameter #7098

denis-sokolov opened this issue Aug 8, 2024 · 1 comment · May be fixed by #7109
Labels
type: typos

Comments

@denis-sokolov
Copy link

Summary

useOptimistic’s second parameter is allegedly optional (source), but the docs imply that it is required.

Page

https://react.dev/reference/react/useOptimistic#parameters

Details

Perhaps in the Reference section, Parameters, under updateFn, it could be mentioned that the function is optional, and that the returned function addOptimistic will instead be a setter (setOptimistic).
@denis-sokolov denis-sokolov mentioned this issue Aug 8, 2024
Closed
@AkashJana18 AkashJana18 linked a pull request Aug 16, 2024 that will close this issue
Open
@AkashJana18
Copy link

Hi @denis-sokolov ,
I wanted to follow up on this pull request and see if there's anything else you need from me or any additional changes you'd like to see. Please let me know if you have any feedback or if there's a timeline for review.
Thanks for your time and consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: typos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/7098 useOptimistic document AkashJana18/react.dev
2 participants
@denis-sokolov @AkashJana18