Update and fix gh actions #6651
Open
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
alinkedd
force-pushed
the
update-and-fix-gh-actions
branch
from
802097f
to
ecaad6a
Compare
alinkedd
force-pushed
the
update-and-fix-gh-actions
branch
from
ecaad6a
to
1fded7f
Compare
|
@gaearon @harish-sethuraman could you please help to find someone to review this PR regarding GH actions? It would be great to have them fixed. duplicates #6179 (comment) |
alinkedd
force-pushed
the
update-and-fix-gh-actions
branch
from
1fded7f
to
ef622a3
Compare
alinkedd
force-pushed
the
update-and-fix-gh-actions
branch
from
ef622a3
to
b985ceb
Compare
alinkedd
force-pushed
the
update-and-fix-gh-actions
branch
from
b985ceb
to
60e7311
Compare
|
@poteto hi |
poteto
requested changes
Nov 5, 2024
| @@ -55,7 +55,7 @@ jobs: | |||
| name: bundle_analysis.json | |||
|
|
|||
| - name: Download base branch bundle stats | |||
| uses: dawidd6/action-download-artifact@v2 | |||
| uses: dawidd6/action-download-artifact@v6 | |||
There was a problem hiding this comment.
do we really need an external action for this? could we rewrite this to use https://github.com/actions/toolkit/tree/main/packages/artifact instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
except for the). Close Update and fix gh actions #6651upload-artifactupload-artifactwas bumped to v3, as I'm not sure about the required unique artifact names in v4, though v3 still uses node16. Also close [Bug]:analyzeworkflow fails because of deprecated version ofactions/upload-artifact#7148Upload analysis commentstep)Analyze Bundle (Comment)action failure on the default branch by rewriting the condition, as GitHub's runner evaluation is tricky and sometimes provides false positives. Close [GH workflow] updateanalyze.ymlto avoid noisy notification #5801NOTE: analyze-comment depends on
workflow_runand thus will be used only after merging updates into the default branch. This is why the deprecation warning is still present (https://github.com/reactjs/react.dev/actions/runs/7980542658). To check the proposed fix in a condition, you may look over the same fix in my test repo and then dependant workflow respecting that condition.Thorough review is welcomed, as I'm no GitHub Actions professional :)
UPD
I added folded block to
ifcondition without expression to shorten the line, and it seems to work file. Links to my latest test results are updated.UPD 2
#7277 has already updated most of the actions, so it closes #5961 by updating dawidd6/action-download-artifact at last