Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how StrictMode affects function components and hooks #2515

Merged
merged 6 commits into from
Mar 30, 2020

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 29, 2019

@reactjs-bot
Copy link

reactjs-bot commented Oct 29, 2019

Deploy preview for reactjs ready!

Built with commit d777c53

https://deploy-preview-2515--reactjs.netlify.com

content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
@gaearon
Copy link
Member

gaearon commented Mar 29, 2020

Let's remove "only if it uses Hooks". This really isn't an important detail, and as you sent a PR, we'll change that.

content/docs/strict-mode.md Outdated Show resolved Hide resolved
@gaearon gaearon merged commit 9e5a358 into reactjs:master Mar 30, 2020
@gaearon
Copy link
Member

gaearon commented Mar 30, 2020

I tweaked the explanation a bit to remove distracting details and focus on the essence.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Mar 30, 2020

I tweaked the explanation a bit to remove distracting details and focus on the essence.

That is much better, thanks!

@eps1lon eps1lon deleted the patch-1 branch March 30, 2020 14:38
jhonmike added a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
* - Updated the conference date of React Summit Amsterdam. (reactjs#2860)

- App.js Conf 2020 is cancelled due to the COVID-19

* Update outdated URL in code-splitting.md (reactjs#2870)

* Update outdated URL

Next.js Dynamic Import.

* Update code-splitting.md

Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>

* Explain how StrictMode affects function components and hooks (reactjs#2515)

* Update strict-mode.md

* Fix links

* docs: specify which kind of function component

* Update content/docs/strict-mode.md

* Update strict-mode.md

Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

* Update conferences.md

* Update code-splitting.md

* Update strict-mode.md

Co-authored-by: Vishal Jagtap <jagtap.vishal30@gmail.com>
Co-authored-by: Nhan Doan <2561973+nhantdn@users.noreply.github.com>
Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Co-authored-by: Jhon Mike <jhon.msdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants