Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with rn-splash-screen #1

Open
mehcode opened this issue Aug 19, 2016 · 3 comments
Open

Merge with rn-splash-screen #1

mehcode opened this issue Aug 19, 2016 · 3 comments

Comments

@mehcode
Copy link

mehcode commented Aug 19, 2016

It looks like you've got a great start here @tdzl2003

What do you say about consolidating with rn-splash-screen ?

https://github.com/mehcode/rn-splash-screen

@tdzl2003
Copy link
Member

tdzl2003 commented Aug 22, 2016

rn-splash-screen uses a extra view to display launch image, which makes config more complex. But this module KEEPS launch image until hide, but this brings a new restriction: You cannot keep launch image too long, or your app will got killed by iOS.

The major reason for using this module is the "white screen" between iOS launch screen and react native view. On Android, white screen before your apps loaded is not a very big problem. If you want solve it, and provide same splash screen between iOS&Android, or you want do much work when launch image is displaying, rn-splash-screen will be better.

So I prefer these two modules(or two way to keep launch image) both exists, which gives us more choices(rn-launch-image is simpler, and rn-splash-screen provides more safety&function). Personally, I use both two module, in my different apps.

@mehcode
Copy link
Author

mehcode commented Aug 22, 2016

rn-splash-screen uses a extra view to display launch image, which makes config more complex. [...]

I ask you to try the recent new release of rn-splash-screen as I've removed all need for configuration (apart from what is required to have a normal launch image). There is detailed documentation and an example.

So I prefer these two modules [...]

With such a small scope (displaying splash screens) I'm sure we can work together to make a single, better module.

@sunnylqm
Copy link

Less is better, if possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants