Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default onErrorDropped to log instead of bubbling error #1431

Closed
smaldini opened this issue Nov 12, 2018 · 2 comments
Closed

Change default onErrorDropped to log instead of bubbling error #1431

smaldini opened this issue Nov 12, 2018 · 2 comments
Labels
type/enhancement A general enhancement warn/behavior-change Breaking change of publicly advertised behavior
Milestone

Comments

@smaldini
Copy link
Contributor

smaldini commented Nov 12, 2018

Should we change the default behavior from bubbling to logging for premature terminated flows observing errors ?

Should we add an extra callback in case like Flux/Mono#onErrorDiscard ?

@smaldini smaldini added this to the Backlog milestone Nov 12, 2018
@smaldini smaldini added the type/enhancement A general enhancement label Nov 12, 2018
@simonbasle simonbasle added the warn/behavior-change Breaking change of publicly advertised behavior label Apr 19, 2019
@simonbasle simonbasle modified the milestones: Backlog, 3.4.0-M1, 3.4.0-M2 May 5, 2020
@simonbasle simonbasle modified the milestones: 3.4.0-M2, 3.4.0-M1 Jun 3, 2020
@simonbasle simonbasle changed the title Change default onOperatorError to log instead of bubbling error Change default onErrorDropped to log instead of bubbling error Jun 3, 2020
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jun 4, 2020

An additional point, beyond the bubble vs log question is what kind of log level to use? Is it seen more as information for debugging or as actual errors to be corrected, and can anything even be done? If there isn't in many cases that would be an argument for DEBUG level as the default.

@simonbasle
Copy link
Member

simonbasle commented Jun 19, 2020

In M1 we'll go with WARN, as onErrorDropped is usually denoting an issue with the source not conforming to Reactive Streams spec.
scratch that, it is already logged as an ERROR.

@bsideup bsideup modified the milestones: 3.4.0-M1, 3.4.0-M2 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement warn/behavior-change Breaking change of publicly advertised behavior
Projects
None yet
Development

No branches or pull requests

4 participants