Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support 'allowPartialChunks' in the HttpDecoderSpec #3899

Closed
reta opened this issue Oct 2, 2024 · 1 comment
Closed

[Feature] Support 'allowPartialChunks' in the HttpDecoderSpec #3899

reta opened this issue Oct 2, 2024 · 1 comment

Comments

@reta
Copy link

reta commented Oct 2, 2024 •
edited
Loading

Motivation

The Netty's HttpDecoderConfig exposes allowPartialChunks property which hints the HttpObjectDecoded if the chunk could be split into multiple when chunk exceeds the readable bytes. The HttpDecoderSpec sadly does not provide the way to configure it.

Desired solution

Support 'allowPartialChunks' in the HttpDecoderSpec so it could be used to create HttpDecoderConfig instances with respective property set.

Considered alternatives

N/A

Additional context

We right now are running into an issue when the complete chunk should be consumed but the partial ones are being produced instead.

@violetagg I am happy to submit the pull request if the feature makes sense to you, thank you
@reta reta added the type/enhancement A general enhancement label Oct 2, 2024
@reta
Copy link
Author

reta commented Oct 2, 2024

Sorry about that, should be filed against reactor-netty (reactor/reactor-netty#3452)

@reta reta closed this as completed Oct 2, 2024
@chemicL chemicL removed the type/enhancement A general enhancement label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reta @chemicL