Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Behavior: httpHeaders Callback Invoked for Every Request Instead of Only During Initial CONNECT in Netty HTTP Client with Proxy #3501

Open
matthew-js-porter opened this issue Nov 6, 2024 · 0 comments
Assignees
Labels
type/bug A general bug

Comments

@matthew-js-porter
Copy link

When configuring a Netty HTTP client to use a proxy, I would have expected the headers callback specified in the ProxyProvider to be called only during the initial CONNECT request to the proxy server and that after the tunnel was created there would be no need to call the headers callback. Is my understanding on the proxy correct or am I completely off base here?

Expected Behavior

The httpHeaders method to be called only when creating the tunnel to the Proxy.

Actual Behavior

The httpHeaders method is ran for every request the httpClient makes.

Steps to Reproduce

Configure HTTP Client with a Proxy like this. When making requests observe that the httpHeaders method is ran for each request.

final var httpClient = HttpClient.create().proxy(proxy -> proxy.type(ProxyProvider.Proxy.HTTP).host(proxyUrl).port(proxyPort).httpHeaders(headers -> {
            System.out.println("in headers");
           //headers.add("Proxy-Authorization", "Negotiate " + getKerberosToken());
        }).build());
  • Reactor version(s) used: Reactor Netty 1.1.22
@matthew-js-porter matthew-js-porter added status/need-triage A new issue that still need to be evaluated as a whole type/bug A general bug labels Nov 6, 2024
@violetagg violetagg self-assigned this Nov 8, 2024
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants