-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Connector to have no Resolver #12
Comments
See #7. The API of the PR is good but see my comment about a Null pattern instead of an exception. Unfortunately the submitter hasn't commented or updated the request. |
I get the Null pattern thing, but isn't it always the case, if your hostname is an ip address, that we don't need the call a dns server? This means that we could include this behaviour in the Resolver itself. It still is the case the some people would not want a Resolver if they're absolutely sure they will be working with ip addresses, but for me that not really an issue for now... |
Ah, I think I see now. This issue belongs in reactphp/dns in that case. |
Big 👍 on the idea, makes perfect sense! Resolving this ticket is also a requisite for using this component as part of the DNS component (reactphp/dns#19).
Yes, this would be one possible solution. Would you care to file a PR to see how this works out? See also #7 and @cboden's suggestion for an alternative implementation.
Indeed, this has been raised several times already. I've filed a relevant feature request ticket in the DNS component to keep track of this: reactphp/dns#17
Nice suggestion, makes perfect sense! I've filed a relevant feature request ticket in the DNS component to keep track of this: reactphp/dns#18 Thanks for discussing these concepts so far! |
As an alternative to a
Just putting this out here. I think it might still be worth implementing, should we consider providing a simpler facade API (see #38). The resulting API could eventually looks like this:
|
See also #46 for a PR which implements the above suggestion. |
...so I can connect to an ip address if I do something locally
It is already possible to call
createSocketForAddress
with the desired ip address, but it doesn't feel right that I need a dns resolver for that. One solution would be to have a resolving connector and non resolving connector. Or are there other suggestions?I'm willing to try something in code if I know what the opinions are...
The text was updated successfully, but these errors were encountered: