-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tagged release #2
Comments
There was talk of incorporation between DNS, datagram, and stream since there's somewhat a circular dependancy between them. Should we hold off on a v1.0 tag until that is figured out? |
The datagram and socket-client (I assume "stream" must have been a typo?) components operate on a different OSI layer than the DNS (edit: In fact, both components do not really require the DNS (edit: That being said, I agree that a circular dependency isn't quite ideal either. It's certainly testament of a design flaw, but other than that, does it really do any harm? |
Any update on getting tags setup? @cboden I am working on name server implementation for DNS @ reactphp/dns#9 and plan on including Datagram as a dependency. Please advise on how dependency needs to be handled for the mentioned PR. Thanks |
👍 I'm good for you to tag v1.0 @clue |
Finally done, updated CHANGELOG and tagged v1.0.0 release (a476b74). |
Thanks @clue |
Now that the source is imported, we should start adding tags so others can rely on this package.
This package was imported from clue/datagram which already had several tags. These were left out intentionally as this would introduce unnecessary noise in this repository (IMHO).
Ideally, we would release this as v1.0.0 and clean up the CHANGELOG accordingly.
The text was updated successfully, but these errors were encountered: