Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tagged release #2

Closed
clue opened this issue Aug 16, 2014 · 6 comments
Closed

Create tagged release #2

clue opened this issue Aug 16, 2014 · 6 comments
Assignees

Comments

@clue
Copy link
Member

clue commented Aug 16, 2014

Now that the source is imported, we should start adding tags so others can rely on this package.

This package was imported from clue/datagram which already had several tags. These were left out intentionally as this would introduce unnecessary noise in this repository (IMHO).

Ideally, we would release this as v1.0.0 and clean up the CHANGELOG accordingly.

@cboden
Copy link
Member

cboden commented Sep 4, 2014

There was talk of incorporation between DNS, datagram, and stream since there's somewhat a circular dependancy between them. Should we hold off on a v1.0 tag until that is figured out?

@clue
Copy link
Member Author

clue commented Sep 6, 2014

The datagram and socket-client (I assume "stream" must have been a typo?) components operate on a different OSI layer than the DNS (edit: datagram) component, so I'm all for keeping them as separate packages.

In fact, both components do not really require the DNS (edit: datagram) component at all. It's merely a convenience feature that allows you to pass hostnames instead of the underlying IP addresses. From a purely functional view-point I'd vote to remove the dependency on the DNS component - though from a practical viewpoint I'd vote to keep it as-is. So if we are to change our repo layout, I'd vote to split the repos here (e.g. datagram-with-dns and datagram-without-dns) to avoid the circular dependency.

That being said, I agree that a circular dependency isn't quite ideal either. It's certainly testament of a design flaw, but other than that, does it really do any harm?

@attozk
Copy link

attozk commented Oct 14, 2014

Any update on getting tags setup?

@cboden I am working on name server implementation for DNS @ reactphp/dns#9 and plan on including Datagram as a dependency. Please advise on how dependency needs to be handled for the mentioned PR.

Thanks

@cboden
Copy link
Member

cboden commented Oct 19, 2014

👍

I'm good for you to tag v1.0 @clue

@clue
Copy link
Member Author

clue commented Oct 23, 2014

Finally done, updated CHANGELOG and tagged v1.0.0 release (a476b74).

@clue clue closed this as completed Oct 23, 2014
@attozk
Copy link

attozk commented Oct 24, 2014

Thanks @clue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants